Skip to content

Improve exhale note QR sizing for scan reliability#339

Merged
kojibai merged 2 commits intomainfrom
codex/fix-qr-code-functionality-on-exhale-note
Jan 31, 2026
Merged

Improve exhale note QR sizing for scan reliability#339
kojibai merged 2 commits intomainfrom
codex/fix-qr-code-functionality-on-exhale-note

Conversation

@kojibai
Copy link
Copy Markdown
Owner

@kojibai kojibai commented Jan 31, 2026

Motivation

  • Make the QR on the Exhale Note larger and better centered so it scans and clicks like the verifier-download PNG (improve quiet zone and label spacing for camera scanners).

Description

  • Increased the Exhale Note QR slot from 110 to 140 pixels and adjusted the QR container height and label position.
  • Increased the QR generator margin passed to makeQrSvgTagSafe from 2 to 3 to provide a larger quiet zone for more reliable scanning.
  • Re-centered the rendered SVG QR by computing integer offsets against the updated slot size.

Testing

  • Started the dev server with npm run dev and it launched successfully.
  • Ran a visual smoke test using Playwright to load /verify and captured a screenshot (artifacts/exhale-note-verify.png) which completed successfully.
  • No unit test suite was executed as part of this change.

Codex Task

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
phi-network-5aii Ready Ready Preview, Comment Jan 31, 2026 4:59am

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6af2e07f1b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kojibai kojibai merged commit 3800598 into main Jan 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant