Skip to content

Revert "Fix verify page exhale-note dialog visibility on mobile"#343

Merged
kojibai merged 1 commit intomainfrom
revert-342-codex/fix-exhale-note-popover-on-mobile
Jan 31, 2026
Merged

Revert "Fix verify page exhale-note dialog visibility on mobile"#343
kojibai merged 1 commit intomainfrom
revert-342-codex/fix-exhale-note-popover-on-mobile

Conversation

@kojibai
Copy link
Copy Markdown
Owner

@kojibai kojibai commented Jan 31, 2026

Reverts #342

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
phi-network-5aii Ready Ready Preview, Comment Jan 31, 2026 6:13pm

Request Review

@kojibai kojibai merged commit 3ccfa12 into main Jan 31, 2026
2 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3e75bc8b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 1049 to 1051
box-shadow: 0 24px 64px rgba(0, 0, 0, 0.55), inset 0 0 0 1px rgba(255,255,255,0.08);
color: var(--ink);
overflow: hidden;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reinstate closed-state hiding for dialog fallback

With the display: none / dialog[open] { display: block; } rules removed, the Exhale Note dialog now relies entirely on native <dialog> UA styles to hide when closed. On browsers that lack native <dialog> support (older iOS Safari / embedded WebViews), unknown elements are rendered inline, so the modal content is always visible even when noteOpen is false and safeShowDialog only toggles the open attribute. That breaks the verify page layout for those mobile users; restoring an explicit closed-state hide (or a data-open-based rule) keeps the fallback path functional.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant