Skip to content

Fix verify page note claim status on exhale#356

Merged
kojibai merged 1 commit intoFix-new-exhale-note-failurefrom
codex/fix-exhale-note-status-in-verify-page
Jan 31, 2026
Merged

Fix verify page note claim status on exhale#356
kojibai merged 1 commit intoFix-new-exhale-note-failurefrom
codex/fix-exhale-note-status-in-verify-page

Conversation

@kojibai
Copy link
Copy Markdown
Owner

@kojibai kojibai commented Jan 31, 2026

Motivation

  • The exhale note flow when opened from the Verify page did not embed the same origin/canonical and send metadata as the Verifier Stamper, which caused UNCLAIMED / CLAIMED status to be incorrect or missing.
  • Ensure notes exhaled from the Verify UI are associated with the correct parent canonical so claim lookups and UI labels behave identically to the Verifier Stamper flow.

Description

  • Added NoteSendPayload/NoteSendResult imports and a normalizeCanonicalHash helper to consistently normalize canonical hashes.
  • Implemented resolveNoteParentCanonical(meta, payload) to prefer payload parent canonical, then embedded canonicalHash, and finally derive a fallback canonical by hashing pulse|beat|stepIndex|chakraDay when necessary.
  • Added noteOriginCanonical memo and handleNoteSend callback on the Verify page to capture resolved parentCanonical, transferNonce, and related fields and to populate noteSendMeta / noteSendPayloadRaw state.
  • Wired originCanonical and onSendNote={handleNoteSend} into the NotePrinter invocation so the Verify-page exhale path emits the same metadata used for claim tracking and status rendering.

Testing

  • No automated tests were executed for this change (no test run requested).

Codex Task

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
phi-network-5aii Ready Ready Preview, Comment Jan 31, 2026 11:40pm

Request Review

@kojibai kojibai merged commit d64e916 into Fix-new-exhale-note-failure Jan 31, 2026
1 of 2 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cb59c28f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +154 to +158
async function resolveNoteParentCanonical(meta: SigilMetadata | null, payload?: NoteSendPayload): Promise<string> {
const fromPayload = normalizeCanonicalHash(payload?.parentCanonical);
if (fromPayload) return fromPayload;
const fromMeta = normalizeCanonicalHash(meta?.canonicalHash);
if (fromMeta) return fromMeta;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use transfer-aware canonical for open child context

When a verified sigil has an open transfer (last transfer lacks a receiver signature), the Stamper flow derives a child canonical via transfer data (computeEffectiveCanonical), but resolveNoteParentCanonical here only trusts meta.canonicalHash or the basic pulse/beat hash. In that state canonicalHash can still be the parent, so notes exhaled from VerifyPage get associated with the parent canonical while the registry/claim lookups for the same sigil use the derived child canonical, leaving getNoteClaimInfo/isNoteClaimed out of sync. Consider reusing the transfer-aware canonical derivation when meta.transfers indicates an open send.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant