Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 972b4f762a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kojibai
added a commit
that referenced
this pull request
Feb 1, 2026
ΦNet Release Notes — v43.0.0 Theme: Exhale Note global-claim propagation is now PWA-proof (without breaking desktop). 🔥 Highlights Global claim propagation is fixed end-to-end for Exhale Notes (including PWA). Claims now propagate reliably even when the iOS “Save / Share / Download” sheet temporarily background-suspends or refreshes the app. Sigil Explorer API routing is hardened. The client now avoids the “POST/GET /sigils/* → 404 on the static host” loop that was hammering retries and cascading into state loss. This is the v42.9.14 hardening that stabilized cleared-cache + PWA flows. Note rotation is now deterministic: when you download a fresh note PNG (child), the parent is confirmed/claimed correctly (and the child stays unclaimed). ✅ What Changed PWA + Mobile Reliability (the core fix) Fix global claim propagation in PWA (merged) and ship PWA-specific claim reliability work. Probe inhale online status in PWA to prevent false “offline” behavior during iOS lifecycle transitions. Fix PWA note claim propagation so claim state survives the download/save lifecycle and returns globally. VerifyPage: Note download / claim timing (no more “claimed on desktop, not on mobile/PWA”) Confirm parent note when downloading fresh PNG (this is the canonical behavior: parent gets claimed after minting child). Fix note claim confirmation for downloaded PNGs (tightens metadata + registry state). Fix note download claim timing (prevents lifecycle races). Trigger note download on pointer events (prevents unmount/gesture timing issues on mobile). Allow note download while claiming / after immediate claim (removes deadlocks and “stuck” states). Update note claim state on download (ensures registry + UI reflect the new truth immediately). Mobile regressions explicitly handled Fix mobile note claim update before download (attempted) and then reverted when it introduced incorrect behavior. Avoid claiming rotated fresh exhale notes (prevents accidentally claiming the newly minted child). Prevent re-downloading claimed exhale notes on mobile (stops repeat-spend UX). Version trail included in this release package This release consolidates the v42.9.x stabilization train through v42.9.14 into a single “this is now stable” drop. 🧠 Why it broke (the real root cause) What you saw (“works in Safari, breaks in PWA when the save sheet pops”) is classic iOS PWA lifecycle behavior: the standalone app can be backgrounded, suspended, or reloaded during the system download/save UI. If your /sigils/* calls temporarily routed to the wrong base (static host → 404), the inhale/registry flush never completed, and the claim never made it into the durable registry—so after the refresh, the UI looked “unclaimed.” This release fixes that by hardening the API client routing + PWA-specific claim/inhale propagation paths. Deployment Notes PWA users: after updating, fully close the PWA and relaunch once to ensure the latest service worker + assets are active (this matters specifically for the “save sheet” lifecycle). If you host on a non-API domain (e.g., static frontend): the /sigils/* client must resolve to the Lah-Mah-Tor API domains (or a real configured proxy). This release’s API client hardening is what prevents the 404 retry storm. Full Changelog (by PR / commit) #384 fix-global-claim-propagation-in-pwa “Probe inhale online status in PWA” “Fix PWA note claim propagation” #373 fix-regression-in-verifypage.tsx “Confirm parent note when downloading fresh PNG” “Fix note claim confirmation for downloaded PNGs” #367 revert mobile claimed-status investigation #366 investigate mobile claimed status issue #365 fix-download-button-unmounting-issue #364 handle immediate claim + download flow #362 fix-mobile-exhale-note-claimed-status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
navigator.onLine === false, which blocked registry/inhale flows and caused claimed notes minted/downloaded in the PWA to not propagate globally.Description
isStandaloneDisplayMode()and updateisOnline()insrc/components/SigilExplorer/registryStore.tsto treat standalone/PWA display mode as online so claim propagation and registry invalidation are not falsely gated.Testing
Codex Task