Merged
Conversation
Add task proposal to handle "no files found" scenarios gracefully. Currently CLI exits with error code 1 when no files are found. Proposal suggests exiting with code 0 since no work to do is not an error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Changed CLI behavior to exit with code 0 instead of 1 when no files are found to process. This treats "no work to do" as a valid state rather than an error condition. Changes: - Remove "Error:" prefix from "no files found" messages - Replace ctx.exit(1) with return for graceful exit - Update test_no_match_found to expect exit code 0 - Update test docstring to reflect graceful exit behavior Rationale: - No files to process is not an error - it's a valid state - Prevents failure of CI/CD pipelines and automated scripts - Consistent with Unix tools (grep, find) that exit 0 on no matches All 17 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes CLI behavior to exit with code 0 instead of 1 when no files are found to process. This treats "no work to do" as a valid state rather than an error condition.
Changes
quarto_batch_convert.py (lines 301-303, 321-326)
ctx.exit(1)withreturnfor graceful exittest_quarto_batch_convert.py (test_no_match_found)
Rationale
Testing
✅ All 17 tests pass
test_no_match_foundnow validates exit code 0Test Scenarios Covered
-rflagAll scenarios now exit with code 0 and informative (non-error) message.
🤖 Generated with Claude Code