Hr graph

[as-j]

Add an HR strip graph to the top of the page like the cadence graph on the bottom. The zone colours match those from garmin, and can be set via the app settings options. There's some error checking to verify the string is ok, but you can't catch errors from string.toNumber()...which can be a problem.

[kopa]

Could you extract that block as a method with a speaking method name that returns the zones, so that the code doesn't get too complex. Would that be ok for you?

[as-j]

Yeah that's easy enough.

I also realized the zones are off by one for color. (Zone 2 is blue, etc).
So I'll fix both while I'm at it.

-Andrew
925-875-8728

On Jan 1, 2016, at 18:22, Konrad Paumann notifications@github.com wrote:

In source/RunnersField.mc
#8 (comment):

 hidden var hasBackgroundColorOption = false;

 function initialize() {
     DataField.initialize();

•    var str = Application.getApp().getProperty("hrZones");
  

Could you extract that block as a method with a speaking method name that
returns the zones, so that the code doesn't get too complex. Would that be
ok for you?

—
Reply to this email directly or view it on GitHub
https://github.com/kopa/RunnersField/pull/8/files#r48676766.

[kopa]

Great feature!