Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

Development#1

Merged
antoineKorbit merged 4 commits intokorbit-ai:developmentfrom
antoineKorbit:development
Apr 14, 2021
Merged

Development#1
antoineKorbit merged 4 commits intokorbit-ai:developmentfrom
antoineKorbit:development

Conversation

@antoineKorbit
Copy link

@antoineKorbit antoineKorbit commented Apr 13, 2021 •
edited
Loading

  • Updating files permissions for the generated jail_code file, otherwise inside the container it wasn't working properly.
  • Fix error with Numpy and Pandas conversion to JSON, because safe_exec is actually grabbing all the result from the execution, using the sdtoutput of the program.
  • I deleted django files because they aren't relevant for us.
  • I deleted the Jenkins file, because I think we should implement github actions instead.

farfaraji
farfaraji approved these changes Apr 14, 2021
View reviewed changes
Copy link

@farfaraji farfaraji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🦾

jopotochnykorbit
jopotochnykorbit approved these changes Apr 14, 2021
View reviewed changes
Copy link

@jopotochnykorbit jopotochnykorbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antoineKorbit antoineKorbit merged commit a7c1364 into korbit-ai:development Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jopotochnykorbit jopotochnykorbit jopotochnykorbit approved these changes

@farfaraji farfaraji farfaraji approved these changes

@stephane-korbit stephane-korbit stephane-korbit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antoineKorbit @jopotochnykorbit @farfaraji @stephane-korbit