This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Move proxy_main.py to be included in codejail module#9
Merged
ariellasmo merged 1 commit intodevelopmentfrom Aug 25, 2022
Merged
Move proxy_main.py to be included in codejail module#9ariellasmo merged 1 commit intodevelopmentfrom
ariellasmo merged 1 commit intodevelopmentfrom
Conversation
Author
|
This will be a breaking change on the default sandbox. Let's not merge until default sandbox uses codejail properly as a proper library. |
| if PROXY_PROCESS is None: | ||
| # Start the proxy by invoking proxy_main.py in our root directory. | ||
| root = os.path.dirname(os.path.dirname(os.path.realpath(__file__))) | ||
| root = os.path.dirname(os.path.realpath(__file__)) |
There was a problem hiding this comment.
How this is a breaking change we aren't using PROXY process in codippy default sandbox 🤔
Author
There was a problem hiding this comment.
I haven't actually looked at the codippy default sandbox at all. I didn't know proxy_main.py was only used in the codippy validation sandbox.
Do you think this PR can be merged now @antoineKorbit ?
There was a problem hiding this comment.
Oh I spotted it, it's declared in the Docker container as ENV variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
proxy_main.pyto be installable as a library.MLA-588