'remove

[etale-cohomology]

I'm trying to build this on Ubuntu LTS 14.04, and I get the following error when trying to run make:

[ 71%] Built target agast_static
[ 78%] Building CXX object CMakeFiles/brisk.dir/src/brisk.cpp.o
/home/diego/git/brisk/src/brisk.cpp: In member function ‘virtual void brisk::BriskFeatureDetector::detectImpl(const cv::Mat&, std::vector<cv::KeyPoint>&, const cv::Mat&) const’:
/home/diego/git/brisk/src/brisk.cpp:659:37: error: ‘removeInvalidPoints’ was not declared in this scope removeInvalidPoints(mask, keypoints);

make[2]: *** [CMakeFiles/brisk.dir/src/brisk.cpp.o] Error 1
make[1]: *** [CMakeFiles/brisk.dir/all] Error 2
make: *** [all] Error 2

[kornerc]

I tried the code on my Ubuntu 14.04 machine with OpenCV 2.4.8 and g++ 4.8.5 and it's working.
I did the following

git clone https://github.com/clemenscorny/brisk.git
mkdir build
cd build
cmake ../brisk
make

Do you use OpenCV from the original ubuntu package repositories and g++?

[dchang0]

I'm getting the exact same error as etale-cohomology--perhaps it is because I am running OpenCV 3.1.0 and not OpenCV 2.4.8... I have g++ 4.9.2 on Debian 8.5.

[etale-cohomology]

I'm also running OpenCV 3.1.0! (Latest development version, from github)

[dchang0]

I'm currently building OpenCV 2.4.13 from Github to see if this BRISK implementation builds properly. (It should.) Hopefully OpenCV 2 and OpenCV 3 can co-exist on the same system...

[dchang0]

I am able to get past the error above after building and installing OpenCV 2.4.13 from the opencv.org Download page. However, it breaks later on with a different error (after a NumPy 1.7 deprecated warning). I'll post that as a separate issue.

[kornerc]

Thank you for the bug report.
I can reproduce this issue with OpenCV 3.1.
Somehow the OpenCV-team removed the function removeInvalidPoints in OpenCV 3.x from features2d
OpenCV 2.4 opencv2/features2d/features2d.hpp vs OpenCV 3.1 opencv2/features2d.hpp

I'll try to port this function back to the brisk code.

BR Clemens

[dchang0]

Perhaps they moved the function out to xfeatures2d (or some other library)? You might want to check that first before porting...

On Jul 2, 2016, at 14:27, Clemens Korner notifications@github.com wrote:

Thank you for the bug report.
I can reproduce this issue with OpenCV 3.1.
Somehow the OpenCV-team removed the function removeInvalidPoints in OpenCV 3.x from features2d
OpenCV 2.4 opencv2/features2d/features2d.hpp https://github.com/Itseez/opencv/blob/2.4/modules/features2d/include/opencv2/features2d/features2d.hpp#L192 vs OpenCV 3.1 opencv2/features2d.hpp https://github.com/Itseez/opencv/blob/master/modules/features2d/include/opencv2/features2d.hpp
I'll try to port this function back to the brisk code.

BR Clemens

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #2 (comment), or mute the thread https://github.com/notifications/unsubscribe/AIePaqcm2GtsRc9CHg8x1RPJwv6aGfw0ks5qRte9gaJpZM4I-avF.

[mirellameelo]

Do not have "removeInvalidPoints" in xfeatures2d neither in features2d... Still looking for a solution :(