Recognize comments in Janet files

[MaxGyver83]

Fix issue #47 partly.

Janet uses # for comments (Lisp uses ;).

[MaxGyver83]

I guess that it's inefficient to define comment_char in multiple places. But when I add a script-local variable on top of the file, it does not work:

if &ft == 'janet' | let s:comment_char = '#' | else | let s:comment_char = ';' | end

I think at this point, &ft isn't set to janet yet.

[kovisoft]

Thanks for the fix, but I think it does not really conform to the other parts of the filetype and comment handling of paredit. See for example s:fts_balancing_all_brackets, s:fts_multiline_comment or s:fts_datum_comment. The general logic is that we define what languages need support for a specific functionality. It is not 100% sure that the only language using # for comments is going to be janet.

You say that adding a script-local variable on top of the file does not work, because the filetype is defined after the script is loaded. How about doing the same as for the other variables mentioned above? Instead of defining the comment character in a script-local variable, just define the filetype for the # comment character. Then wherever there was a reference to ; we define the comment character based on the filetype (similar to how you are doing it in your pull request, but the filetype defined separately).

For example if we define s:fts_hash_comment as '.*\(janet\).*' then we can use it in s:InsideComment this way:

        let comment_char = ';'
        if &ft =~ s:fts_hash_comment
            let comment_char = '#'
        endif
        return match( line, comment_char ) >= 0

[MaxGyver83]

Thanks for the fix, but I think it does not really conform to the other parts of the filetype and comment handling of paredit. See for example s:fts_balancing_all_brackets, s:fts_multiline_comment or s:fts_datum_comment. The general logic is that we define what languages need support for a specific functionality. It is not 100% sure that the only language using # for comments is going to be janet.

You say that adding a script-local variable on top of the file does not work, because the filetype is defined after the script is loaded. How about doing the same as for the other variables mentioned above? Instead of defining the comment character in a script-local variable, just define the filetype for the # comment character. Then wherever there was a reference to ; we define the comment character based on the filetype (similar to how you are doing it in your pull request, but the filetype defined separately).

For example if we define s:fts_hash_comment as '.*\(janet\).*' then we can use it in s:InsideComment this way:

        let comment_char = ';'
        if &ft =~ s:fts_hash_comment
            let comment_char = '#'
        endif
        return match( line, comment_char ) >= 0

Sure, this makes totally sense!