fix: handle non-decomposable diacritics in stripDiacritics#816
Closed
lkostrowski wants to merge 1 commit intokrisk:mainfrom
Closed
fix: handle non-decomposable diacritics in stripDiacritics#816lkostrowski wants to merge 1 commit intokrisk:mainfrom
lkostrowski wants to merge 1 commit intokrisk:mainfrom
Conversation
Some characters survive NFD normalization unchanged. Add explicit replacement map for these characters.
13 tasks
Owner
|
Thanks for this — landed in 5a01f29. Applied your approach to the TypeScript source (the codebase was rewritten to TS since this PR was opened) and added tests for Polish (ł), German (ß), Danish (ø), Serbian (đ), and Maltese (ħ) characters. Appreciated the Home Assistant reference — good to know it's battle-tested there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some characters survive NFD normalization unchanged. Add explicit replacement map for these characters.
Originally implemented in home-assistant/frontend#30399 but probably should be part of Fuse