chore(github): add CODEOWNERS field to RFC issue template#99
Open
krokoko wants to merge 1 commit into
Open
Conversation
Add an optional input field to the RFC template asking submitters to specify the GitHub team that will own new plugin code. This surfaces the CODEOWNERS requirement early in the proposal process. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Task-Id: 01KSRXP6F4H3PJ3QJEAME9B4PK Prompt-Version: 1c9c10e027a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New CODEOWNERS fileinput field to.github/ISSUE_TEMPLATE/rfc.yml@awslabs/agent-plugins-my-new-plugin) that will own the code for any new plugin or major component introduced by their proposalMotivation
The existing CODEOWNERS file and its associated instructions (
.github/instructions/codeowners.instructions.md) establish strict rules for team ownership. By surfacing this requirement in the RFC template, owners can be identified early in the design process rather than at PR review time.Build & Test Results
mise run build— ✅ passed (lint, fmt:check, security scans all clean)Decisions
The new field is placed before the final admin metadata block (RFC PR / Approved by / Reviewed by), keeping it visible but clearly optional and out of the critical RFC content sections.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.
Agent notes
What went well: The task was straightforward — the RFC template and CODEOWNERS file were easy to locate and understand. The codeowners instructions file gave clear context on what ownership entries should look like, which directly informed the placeholder text and description for the new field.
What was difficult: Nothing significant. The main judgment call was where to place the new field within the existing form structure.
Patterns discovered:
.github/instructions/codeowners.instructions.md— any future plugin additions need that file updated following the 5-point checklistmise run buildruns lint + fmt:check + security and is the single required validation gate<type>(<module>): description) as the PR title convention.tmp/are the preferred workflow for parallel work, but since this branch was already set up, direct commits were appropriate hereSuggestions for future tasks: