Skip to content

Another attempt at fixing the damn alert #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshk123 merged 1 commit into from
Nov 26, 2025
Merged

Another attempt at fixing the damn alert #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion network_speed/grafana/terraform/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ resource "grafana_rule_group" "internet_speed_alerts" {
expression = "A"
reducer = "last"
settings = {
mode = "strict"
mode = "dropNN" # drop null/NaN values; alternative: replaceNN
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "replaceNN" as an alternative, but the correct Grafana reduce mode is "replaceNon" (not "replaceNN"). The mode "replaceNon" replaces non-numeric values with a specified value.

Suggested change
mode = "dropNN" # drop null/NaN values; alternative: replaceNN
mode = "dropNN" # drop null/NaN values; alternative: replaceNon

Copilot uses AI. Check for mistakes.
}
})
}
Expand Down