Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

newConstructor doesn't honor argument order? #133

@redbaron

Description

@redbaron

both ContainerPort and ServicePort use newConstructor("newNamed", newParam("name"), ... )

but ContainerPort has argument names swapped, at least when generated from ksonnet with v1.8.0 apisepc:

containerPort:: {
    newNamed(containerPort="", name=""):: self.withContainerPort(containerPort).withName(name),

while order of args in ServicePort seems to be matching args to newConstructor:

servicePort:: {
...
    newNamed(name="", port="", targetPort=""):: self.withPort(port).withTargetPort(targetPort) + self.mixin.metadata.withName(name),

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions