feat: formalize an experimental post type#2
Merged
cesarenaldi merged 1 commit intomainfrom Jun 20, 2025
Merged
Conversation
cesarenaldi
commented
Jun 18, 2025
| * A sub-identifier for the custom post type. | ||
| * This is used to differentiate between different custom post types. | ||
| */ | ||
| name: string; |
Collaborator
Author
There was a problem hiding this comment.
I need to discuss internally how this could be leveraged for some sort of filtering.
cesarenaldi
commented
Jun 18, 2025
|
|
||
| name: NonEmptyStringSchema.describe( | ||
| 'A sub-identifier for the custom post type. This is used to differentiate between different custom post types.', | ||
| ), |
Collaborator
Author
There was a problem hiding this comment.
What used to be value (a JSON string) should be done with attributes in the most typed way if possible (at first) with JSONString attribute as last resort.
Owner
|
hey @cesarenaldi do you need this merged? lmk if i can help with anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.