This repository was archived by the owner on Jan 31, 2022. It is now read-only.
Use a configmap to make the model configurable; setup ACM for label bot#152
Merged
k8s-ci-robot merged 1 commit intokubeflow:masterfrom Jun 30, 2020
Merged
Use a configmap to make the model configurable; setup ACM for label bot#152k8s-ci-robot merged 1 commit intokubeflow:masterfrom
k8s-ci-robot merged 1 commit intokubeflow:masterfrom
Conversation
* The AutoML model was hardcoded * Use a configmap to provide a YAML file which contains the AutoML model link. This will make it easier to automate updating the model. * Fix#149 Link in dashboard comment is wrong; need to link to the mlapp * Fix#150 pin the keras version because otherwise ktext pulls in a newer version which requires TensorFlow 2 * Use ACM to deploy label-bot-prod * Setup the directory acm-repos to contain a nomos repo * Redirect .build to the ACM directory. * Add ACM configs.
|
This change is |
Contributor
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AutoML model was hardcoded
Use a configmap to provide a YAML file which contains the AutoML model
link. This will make it easier to automate updating the model.
Fix#149 Link in dashboard comment is wrong; need to link to the mlapp
Fix#150 pin the keras version because otherwise ktext pulls in a newer
version which requires TensorFlow 2
Use ACM to deploy label-bot-prod
Add ACM configs.