[WIP] ARM-Support#481
Closed
ckotzbauer wants to merge 1 commit intomainfrom
Closed
Conversation
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
ckotzbauer
added
enhancement
Contributor
|
Glad someone else is concerned about arm64 builds. I've provided an alternative to this PR here: This is a more traditional multi-arch build support approach on github actions using qemu and docker buildx with multi-platform support. No changes to existing makefile were required, but I did move some of the go-build steps to the Dockerfile. Not entirely sure about the approach listed here, but I'm not sure it would generate a multiple-arch manifest, whereas the approach in 496 will. |
|
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days). |
Member
Author
|
superseded by #496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP-PR of a build with ARM support.
I'm not really sure about the changes in the Makefile. With the changes for windows-support in mind from #460 this would create more and more complicated tooling-scripts to maintain.
My personal favourite is to do only the go-compilation and other small tasks in the makefile and move the image build and -publish to Github Actions which are already able to create multiarch-builds out of the box. But this would remove the ability to create images locally (without writing the commands on your own).
I also would suggest to not separate different architectures by image-tag and use the same tags for different arches.
WDYT?
Ref: #23