Skip to content

Conversation

@davidgamero
Copy link
Contributor

main was generated with the release-1.35 branch, which is not a fixed tag

this means when someone opens a PR after the first 1.35.x patch release their PR will require those changes to be included.

if this was the intended behavior i will change export KUBERNETES_BRANCH="v1.35.0" to export KUBERNETES_BRANCH="release-1.35"

either way, this PR is to align the settings file and src/gen folder.

the GEN_COMMIT variable is updated to match what was used in #2732 based on the inclusion of enum changes i noticed here https://github.com/kubernetes-client/javascript/pull/2732/changes#diff-53a4fc8b730eb7a699aab421052cfa52ddf8d6eb973bd03e58bc1c96d1dd4c96

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2026
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cjihrig,davidgamero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa0fa79 into kubernetes-client:main Jan 6, 2026
10 checks passed
@mstruebing
Copy link
Member

mstruebing commented Jan 6, 2026

While we are at it - does anything speak against releasing a new version?
I've noticed the other clients didn't do this as well yet, is there a reason why we would want to wait?

If so, I can do it but I didn't want to waste time/effort.

cc @brendanburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants