Add since_time parameter to read_namespaced_pod_log

[neelsomani]

What happened (please include outputs or screenshots):

The docstring makes reference to both the sinceSeconds and sinceTime parameters which exist in the CLI, but I see that only the since_seconds kwarg is accepted by the Python client

What you expected to happen:

I expected the since_time kwarg to be accepted

How to reproduce it (as minimally and precisely as possible):

Pass since_time attribute to the CoreV1Api method read_namespaced_pod_log

Anything else we need to know?:

n/a

Environment:

• Kubernetes version (kubectl version): v1.19.0
• OS (e.g., MacOS 10.13.6): Linux
• Python version (python --version) 3.6.10
• Python client version (pip list | grep kubernetes) 12.0.0

[neelsomani]

Would be happy to add this parameter myself, just not sure how - I saw the CoreV1Api code is generated so I figure I'm not supposed to edit that directly

[pigletfly]

actually, it's supported already, read_namespaced_pod_log(self, name,namespace, **kwargs), just pass since_seconds in kwargs.

[neelsomani]

Yeah I'm currently using since_seconds, this issue is about since_time though

[yliaog]

/cc

[yliaog]

both since_time and since_seconds were added years ago, https://github.com/kubernetes/kubernetes/blame/c5cc25d1cb075f84756db9bffecd3fafe12c5fab/pkg/apis/core/types.go#L4427

[neelsomani]

Interesting, it didn't seem to work for me with the Python client but I ended up not needing this feature anyway. I'm fine with closing the issue.

[yliaog]

https://github.com/kubernetes/kubernetes/blob/083290d996cd0707bfb9810eb17cc7d5652863b8/staging/src/k8s.io/api/core/v1/types_swagger_doc_generated.go#L1558

has both since_time and since_seconds

[neelsomani]

Yeah totally fine with closing it but just wondering, why is there no since_time parameter mentioned in the generated code here: https://raw.githubusercontent.com/kubernetes-client/python/master/kubernetes/client/api/core_v1_api.py

[yliaog]

https://raw.githubusercontent.com/kubernetes/kubernetes/master/api/openapi-spec/swagger.json is the openapi spec used for generating python client in this repo. sinceseconds is present there, but sincetime is not.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten