Loading configuration file fails when insecure-skip-tls-verify is false

[ganchurin]

What happened:
Loading configuration file with config.load_kube_config() failed with the following error:

Traceback (most recent call last):
  File "TestK8Client.py", line 4, in <module>
    config.load_kube_config()
  File "/usr/local/lib/python2.7/site-packages/kubernetes/config/kube_config.py", line 649, in load_kube_config
    loader.load_and_set(config)
  File "/usr/local/lib/python2.7/site-packages/kubernetes/config/kube_config.py", line 462, in load_and_set
    self._load_cluster_info()
  File "/usr/local/lib/python2.7/site-packages/kubernetes/config/kube_config.py", line 433, in _load_cluster_info
    self.verify_ssl = not self._cluster['insecure-skip-tls-verify']
  File "/usr/local/lib/python2.7/site-packages/kubernetes/config/kube_config.py", line 499, in __getitem__
    % (key, self.name))
kubernetes.config.config_exception.ConfigException: Invalid kube-config file. Expected key insecure-skip-tls-verify in [EDITED]/.kube/config/{'cluster': {'insecure-skip-tls-verify': False, 'certificate-authority-data': [EDITED], 'server': [EDITED]}, 'name': [EDITED]}/cluster

How to reproduce it:
The configuration file must include the following lines:

clusters:
- cluster:
    insecure-skip-tls-verify: false

Anything else we need to know?:
Java-client works fine with the same configuration file.

Environment:

• Kubernetes version: v1.11.8
• OS: MacOS 10.14.6
• Python version: 2.7.13
• Python client version: 10.0.1

[roycaihw]

I can reproduce this issue with v10.0.1. Interestingly having insecure-skip-tls-verify: true works fine. I think there is something wrong in the getter

/good-first-issue

[k8s-ci-robot]

@roycaihw:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

Details

In response to this:

I can reproduce this issue with v10.0.1. Interestingly having insecure-skip-tls-verify: true works fine. I think there is something wrong in the getter

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ganchurin]

@roycaihw If there are no objections, I will work on this.

[micw523]

Go for it - enjoy!

[ganchurin]

/assign @ganchurin

[ganchurin]

@roycaihw The corresponding PR was merged. Do I correctly understand that now I should propagate changes from python-base into python repository? Thanks!

[roycaihw]

Yes, please open a PR to update the python-base submodule, e.g. #911

[ganchurin]

Already done in #969

[micw523]

/close
Thanks!

[k8s-ci-robot]

@micw523: Closing this issue.

Details

In response to this:

/close
Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.