Skip to content

Update python-base submodule#475

Merged
roycaihw merged 2 commits intokubernetes-client:masterfrom
roycaihw:update-base
Mar 9, 2018
Merged

Update python-base submodule#475
roycaihw merged 2 commits intokubernetes-client:masterfrom
roycaihw:update-base

Conversation

@roycaihw
Copy link
Member

@roycaihw roycaihw commented Mar 8, 2018

ref #445

CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
# v6.0.0b1
- Update python-base submodule: config loader now raises exception on duplicated name in kubeconfig [kubernetes-client/python-base#47](https://github.com/kubernetes-client/python-base/pull/47)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want "Update python-base submodule:". That is an implementation detail and users don't care about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mbohlool
Copy link
Contributor

mbohlool commented Mar 9, 2018

/lgtm please merge after a green ci

@roycaihw roycaihw merged commit 3888bee into kubernetes-client:master Mar 9, 2018
@roycaihw roycaihw deleted the update-base branch March 9, 2018 21:50
@roycaihw
Copy link
Member Author

roycaihw commented Mar 9, 2018

@mbohlool Done. Thanks for reviewing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants