Skip to content

Bump golangci-lint#628

Closed
ash2k wants to merge 1 commit intokubernetes-sigs:masterfrom
ash2k:ash2k/new-linter
Closed

Bump golangci-lint#628
ash2k wants to merge 1 commit intokubernetes-sigs:masterfrom
ash2k:ash2k/new-linter

Conversation

@ash2k
Copy link
Copy Markdown
Member

@ash2k ash2k commented Aug 8, 2023

Maybe this will resolve the linter being killed in #619? I have no idea why it's getting killed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@seans3
Copy link
Copy Markdown
Contributor

seans3 commented Aug 8, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@seans3
Copy link
Copy Markdown
Contributor

seans3 commented Aug 8, 2023

/hold

Reconcile with this? #627

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 9, 2023

@ash2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cli-utils-presubmit-master 4054234 link true /test cli-utils-presubmit-master
cli-utils-presubmit-master-stress 4054234 link true /test cli-utils-presubmit-master-stress

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ash2k ash2k closed this Aug 9, 2023
@ash2k ash2k deleted the ash2k/new-linter branch August 9, 2023 02:57
@ash2k
Copy link
Copy Markdown
Member Author

ash2k commented Aug 9, 2023

Opened #629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlkfi karlkfi Awaiting requested review from karlkfi

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@seans3 seans3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ash2k @seans3 @k8s-ci-robot