-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Log events that trigger reconciles #1186
Copy link
Copy link
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
As an controller author/user, it would be helpful to know which event has triggered a reconcile, especially in situations where a reconcile can be triggered by changes to multiple resources.
What I have in mind is to log the event in the EnqueueRequestForObject event handlers: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/handler/enqueue.go#L37-L91