Skip to content

improve contributing guide#130

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
interma:more_contri
Sep 4, 2018
Merged

improve contributing guide#130
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
interma:more_contri

Conversation

@interma
Copy link
Copy Markdown
Contributor

@interma interma commented Aug 31, 2018

  1. More detailed test steps
  2. The solution to issues which I have encountered.

Thanks for review.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2018
DirectXMan12
DirectXMan12 suggested changes Sep 4, 2018
View reviewed changes
Comment thread CONTRIBUTING.md

1. Setup tools
```bash
$ go get -u github.com/golang/dep/cmd/dep
Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch dep from master is not recommended. They occaisonally break things on master. Generally, you should use a dep released versoin.

Comment thread CONTRIBUTING.md
```
1. Test
```bash
TRACE=1 ./hack/check-everything.sh
Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-everything tries to download a bunch of stuff. I'd recommend running test-all.sh and verify.sh separately instead (might be a bit faster too).

Copy link
Copy Markdown
Contributor Author

@interma interma Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DirectXMan12 Thanks for your comments.
Considering this PR is merged, I will try and update them in future.

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: interma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eac6912 into kubernetes-sigs:master Sep 4, 2018
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#130 from interma/more_contri
38b9c17 
improve contributing guide
@interma interma mentioned this pull request Dec 12, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

1 more reviewer

@DirectXMan12 DirectXMan12 DirectXMan12 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@interma @k8s-ci-robot @DirectXMan12 @droot