🐛 Fix log depth for DelegatingLogSink#1975
🐛 Fix log depth for DelegatingLogSink#1975k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
1da8d8c to
9940425
Compare
|
It looks like the linter is broken |
|
/assign @alvaroaleman |
9940425 to
ca3b341
Compare
|
looks like golangci-lint is too old |
|
I think it should pass after #1976 |
|
@alculquicondor can you rebase? It doesn't look like github actions merges into the base prior to reading the job config, I re-ran the action and it still uses the old golang-ci lint version: https://github.com/kubernetes-sigs/controller-runtime/runs/7795811041?check_suite_focus=true#step:3:16 |
ca3b341 to
797c6b5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1737
Adds a depth of 1 to the DelegatingLogSink sink, instead of a global depth to the zapr sink.
This global depth is problematic because it doesn't apply to loggers obtained with
WithNameorWithValues.Notes for reviewer
To see this fix in action (and the bug before this fix), go to
examples/scratch-env/main.goand set Development mode to false.