✨ Bump golangci lint to v1.49.0#1987
✨ Bump golangci lint to v1.49.0#1987sbueringer wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| text: "G304: Potential file inclusion via variable" | ||
| - linters: | ||
| - revive | ||
| text: "package-comments: should have a package comment" |
There was a problem hiding this comment.
If we want to add package comments everywhere I would suggest to do that in follow-up PRs (I can open an issue for it).
There are a lot of packages with missing package comments
|
There are 4 open godot findings. In my opinion all false positives. I see the following options:
|
51fbff5 to
b46562b
Compare
I'd be in favor of that |
b46562b to
b9a9086
Compare
|
@sbueringer: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Done. Not sure what happened. Tried to do a commit -amend with GitHub codespaces and that somehow closed the PR :/ New PR here: #1988 |
No description provided.