Skip to content

Fix log format#217

Closed
jzwlqx wants to merge 1 commit into
kubernetes-sigs:masterfrom
jzwlqx:master
Closed

Fix log format#217
jzwlqx wants to merge 1 commit into
kubernetes-sigs:masterfrom
jzwlqx:master

Conversation

@jzwlqx
Copy link
Copy Markdown

@jzwlqx jzwlqx commented Nov 19, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jzwlqx
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: droot

If they are not already assigned, you can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2018
@interma
Copy link
Copy Markdown
Contributor

interma commented Nov 21, 2018

Hi @jzwlqx
The logging line has an issue, and I am working on another PR to deal with it:
#193

You can also do the same as my PR, then merge any of them into master is ok.

@DirectXMan12
Copy link
Copy Markdown
Contributor

This is fixed by #193. Thanks for your contribution, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants