Skip to content

⚠ Expose Manager.Cache/Client options, deprecate older opts#2199

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
vincepri:manager-opts-refactor
Feb 20, 2023
Merged

⚠ Expose Manager.Cache/Client options, deprecate older opts#2199
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
vincepri:manager-opts-refactor

Conversation

@vincepri
Copy link
Copy Markdown
Member

@vincepri vincepri commented Feb 15, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2023
@vincepri vincepri force-pushed the manager-opts-refactor branch from 964ccb6 to f15577b Compare February 15, 2023 17:03
sbueringer
sbueringer reviewed Feb 15, 2023
View reviewed changes
Comment thread pkg/cache/cache.go Outdated
Comment thread pkg/manager/manager.go
Comment thread pkg/manager/manager.go Outdated
@vincepri vincepri force-pushed the manager-opts-refactor branch from f15577b to eb78ee6 Compare February 15, 2023 20:52
@vincepri
Expose Manager.Cache/Client options, deprecate older opts
0377e0f 
Signed-off-by: Vince Prignano <vincepri@redhat.com>
@vincepri vincepri force-pushed the manager-opts-refactor branch from eb78ee6 to 0377e0f Compare February 20, 2023 16:18
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 20, 2023

@vincepri: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff-master eb78ee6 link false /test pull-controller-runtime-apidiff-master
pull-controller-runtime-apidiff 0377e0f link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Copy Markdown
Member

sbueringer commented Feb 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 25ffade into kubernetes-sigs:main Feb 20, 2023
@tiraboschi tiraboschi mentioned this pull request May 22, 2023
Merged
11 tasks
@ahmetb ahmetb mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vincepri @k8s-ci-robot @sbueringer