🐛 Use http client from leaderElectionConfig#2464
🐛 Use http client from leaderElectionConfig#2464k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
|
Hi @troy0820. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/cherry-pick release-0.16 |
|
@sbueringer: new pull request created: #2468 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
During creation of the manager, the default
cluster.HTTPClientis being used during leader election causing cert issues and not responding to events because of the conflict of the kubeconfig it uses for the manager. It never uses the kubeconfig from the leaderElectionConfig when being set.This PR sets that value and creates a httpClient from the restConfig passed in on the
options.LeaderElectionConfigResolves #2454