🌱 Allow envtest WebhookInstallOptions to modify webhooks conditionally#2554
Closed
vincepri wants to merge 1 commit intokubernetes-sigs:mainfrom
Closed
🌱 Allow envtest WebhookInstallOptions to modify webhooks conditionally#2554vincepri wants to merge 1 commit intokubernetes-sigs:mainfrom
vincepri wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Currently, envtest takes a input from a number of CRDs and blindly overrides any service with its own host:port URL. The following change adds a new option to select which services to override based on namespace/name combination. Signed-off-by: Vince Prignano <vincepri@redhat.com>
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
Author
|
/close Superseded by #2555 |
Contributor
|
@vincepri: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, envtest takes a input from a number of CRDs and blindly overrides any service with its own host:port URL.
The following change adds a new option to select which services to override based on namespace/name combination.