⚠️ [WIP] Extend builder with generic For, Owns and Watches#2784
⚠️ [WIP] Extend builder with generic For, Owns and Watches#2784Danil-Grigorev wants to merge 7 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
- Add controller adapters Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Danil-Grigorev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fffe024 to
4d77004
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
3e4a6a2 to
8984b30
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
9179c03 to
ebea1b0
Compare
|
@Danil-Grigorev: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I think this got superseded by #2783, feel free to re-open if you think otherwise. |
|
I believe this PR brings some of the bringing changes on top of #2783, but it deserves a separate issue and a rebase on the core for generics which was implemented. Just didn’t have time to pick this one up yet. |
Creating this to compare implementations and help with examples and discussion on #2214