⚠️ Update Kubernetes client libraries to 1.15.0 release

[tamalsaha]

Signed-off-by: Tamal Saha tamal@appscode.com

[tamalsaha]

In cluster-api project, we are looking to switch to go.mod, v2 project structure, k8s 1.15.0 in one sweep.

xref: kubernetes-sigs/cluster-api#1025

[tamalsaha]

/assign @DirectXMan12

[vincepri]

Are there any major blockers to get this merged? 1.15 brings beta support for CustomResourceWebhookConversion :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamalsaha
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tamalsaha]

@DirectXMan12 , pr is ready for review. I have fixed the conflicts from the jsonpatch fix.

[jimmidyson]

FWIW... LGTM... I'd like to see these libraries updated for 1.15.0 ASAP too.

[DirectXMan12]

whoops, looks like there's an extra commit, and you've checked in the vendor directory, which we stopped doing.

[tamalsaha]

@DirectXMan12 , it is fixed now. I think vendor folder should be added to .gitignore file.

[tamalsaha]

@DirectXMan12 / @mengqiy / @droot , anyone mind taking a look? Are there any blockers to getting this merged?

[vincepri]

Any updates on this?

[lilic]

@tamalsaha @DirectXMan12 I think we should hold off on this, until after the v0.2.0 release is cut, that way we have a release that bumps to the kubernetes version1.14. Otherwise, we need a separate release that cherry-picks this one out and that might be a bit more difficult.

[DirectXMan12]

/hold

we'll do a couple releases in quick succession for this (v0.2.0 and v0.2.1) assuming there's nothing breaking here (will need to double-check, but I don't think so).

[seh]

I'm not sure if it's related, but #500—though closed—describes some version incompatibilities with the dependencies.

[magrossm]

I'm not sure if it's related, but #500—though closed—describes some version incompatibilities with the dependencies.

@ALL, I just installed and I also get the cannot find /appscode/jsonpatch message. Is it going to be fixed since the issue was closed. Afaisee still a problem.

[tamalsaha]

@magrossm , this library now lives here: https://github.com/gomodules/jsonpatch

You should use gomodules.xyz/jsonpatch@v2.0.1

[tamalsaha]

Folks, I am not looking to further work on this pr. So, I am closing this. Feel free to copy/create a new pr.

[magrossm]

@magrossm , this library now lives here: https://github.com/gomodules/jsonpatch

You should use gomodules.xyz/jsonpatch@v2.0.1

Yes but how do I bind it in? I want to install clusterapi clusterctl and I cannot find go.mod.

$ git clone https://github.com/kubernetes-sigs/cluster-api $GOPATH/src/sigs.k8s.io/cluster-api $ cd $GOPATH/src/sigs.k8s.io/cluster-api/cmd/clusterctl/ $ go build

[DirectXMan12]

Yeah, sorry about all the delay @tamalsaha. We'll prob pick this up shortly now that v2 is out.

[DirectXMan12]

@magrossm please ask the cluster-api folks. They're probably using dep (if you see a Gopkg.tom file)