Prompt to install CRD manually when Kind no found

[interma]

Fix: kubernetes-sigs/kubebuilder#337

New output:

$ make run
go generate ./pkg/... ./cmd/...
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
go run ./cmd/manager/main.go
2018/08/10 14:44:52 Registering Components.
2018/08/10 14:44:52 No kind {core.hawq.org MyResource} found, please install CRD in advance.
exit status 1
make: *** [run] Error 1

Thanks for the review.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: interma
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[droot]

I am wondering if we should add more context in the error in the controller-runtime library itself instead of putting the logic in generated code, WDYT ?

[interma]

My thoughts:
Generally, lib (controller-tools) emits all errors and client (kubebuilder) decides what behavior to perform. Based on this point, my PR make sense.

But considering our client code is generated, more concise the better. I think to handle this error in controller-tools is also a good idea. Do you have some ideas about which code should I modify?

Thanks!

[interma]

@droot just a ping, any thoughts?

[droot]

Sorry, didn't follow this thread.

Actually, our client code is no longer generated. Kubebuilder project uses client pkg from https://github.com/kubernetes-sigs/controller-runtime. May be, we can just wrap the error when returning from client's pkg. Can you pl. investigate.

[interma]

Sure, I will check later.
I will ping you if have some problems. Thanks.

[interma]

@droot I opened a new PR in controller-runtime:
kubernetes-sigs/controller-runtime#129

Please help to review, thanks.

[droot]

closing this PR for now.