Skip to content

🐛 Revert Fix the generation of listType=set#754

Merged
k8s-ci-robot merged 1 commit into
masterfrom
revert-753-fix-generation-of-sets
Dec 20, 2022
Merged

🐛 Revert Fix the generation of listType=set#754
k8s-ci-robot merged 1 commit into
masterfrom
revert-753-fix-generation-of-sets

Conversation

@vincepri
Copy link
Copy Markdown
Member

@vincepri vincepri commented Dec 20, 2022

Reverts #753

Which could have side-effects with existing CRDs and should be reverted, upstream fix is incoming for the same issue

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2022
@vincepri vincepri changed the title Revert ":bug: Fix the generation of listType=set" 🐛 Revert Fix the generation of listType=set Dec 20, 2022
@camilamacedo86
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2022
@vincepri
Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri
Copy link
Copy Markdown
Member Author

/cherry-pick release-0.11

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@vincepri: new pull request created: #755

Details

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman alvaroaleman deleted the revert-753-fix-generation-of-sets branch December 20, 2022 19:26
@jdef
Copy link
Copy Markdown

jdef commented Dec 20, 2022

is there a link somewhere to a list of side effects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants