Skip to content

Refactor the openstack provider code#1586

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ramineni:refactor-instances
Aug 10, 2021
Merged

Refactor the openstack provider code#1586
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ramineni:refactor-instances

Conversation

@ramineni
Copy link
Copy Markdown
Contributor

@ramineni ramineni commented Jul 6, 2021 •
edited
Loading

What this PR does / why we need it:
This PR refactors/moves the provider code for better readability and also removes the unused code in the repo

/kind cleanup
Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@ramineni
Refactor the openstack provider code
6e16b3b 
This PR refactors/moves the provider code for better readability.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from Fedosin and anguslees July 6, 2021 10:12
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 6, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 6, 2021

Build succeeded.

@ramineni
Copy link
Copy Markdown
Contributor Author

ramineni commented Jul 20, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 20, 2021

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 20, 2021

Build failed.

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Jul 26, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 26, 2021

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 26, 2021

Build failed.

@ramineni
Copy link
Copy Markdown
Contributor Author

ramineni commented Jul 27, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 27, 2021

@ramineni: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingxiankong
Copy link
Copy Markdown
Contributor

lingxiankong commented Jul 27, 2021

/override openlab/cloud-provider-openstack-e2e-test-csi-cinder

Safe to override.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 27, 2021

@lingxiankong: Overrode contexts on behalf of lingxiankong: openlab/cloud-provider-openstack-e2e-test-csi-cinder

Details

In response to this:

/override openlab/cloud-provider-openstack-e2e-test-csi-cinder

Safe to override.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingxiankong
Copy link
Copy Markdown
Contributor

lingxiankong commented Jul 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@ramineni
Copy link
Copy Markdown
Contributor Author

ramineni commented Aug 9, 2021

@jichenjc All the jobs are run on this PR before . safe to merge. PTAL

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Aug 9, 2021

@jichenjc All the jobs are run on this PR before . safe to merge. PTAL

on my todo list, will look soon

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Aug 10, 2021

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9b8de65 into kubernetes:master Aug 10, 2021
pierreprinetti pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Aug 23, 2021
@ramineni @pierreprinetti
Refactor the openstack provider code (kubernetes#1586)
f240a44 
This PR refactors/moves the provider code for better readability.
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@ramineni
Refactor the openstack provider code (kubernetes#1586)
492d0c4 
This PR refactors/moves the provider code for better readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@lingxiankong lingxiankong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ramineni @k8s-ci-robot @jichenjc @lingxiankong