[manila-csi-plugin] Add options for passing mount opts to cephfs-csi#1605
Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom Jul 23, 2021
Merged
Conversation
This commit adds two new options specific to cephfs-csi to ControllerVolumeContext and NodeVolumeContext: * cephfs-kernelMountOptions, * cephfs-fuseMountOptions
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
|
Build succeeded.
|
|
Build succeeded.
|
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
The docs file is outside pkg/csi/manila so my attempts probabably won't be effective, but they are there for the record. |
Contributor
Author
|
Thank you, @tombarron ! @ramineni could you please take a look? |
|
Build succeeded.
|
Contributor
|
/assign @ramineni |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramineni, tombarron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pierreprinetti
pushed a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Aug 23, 2021
…ubernetes#1605) * added cephfs-csi mount opts to volume context This commit adds two new options specific to cephfs-csi to ControllerVolumeContext and NodeVolumeContext: * cephfs-kernelMountOptions, * cephfs-fuseMountOptions * pass cephfs-kernelMountOptions and cephfs-fuseMountOptions to cephfs-csi * updated docs with new volume context opts
powellchristoph
pushed a commit
to powellchristoph/cloud-provider-openstack
that referenced
this pull request
Jan 19, 2022
…ubernetes#1605) * added cephfs-csi mount opts to volume context This commit adds two new options specific to cephfs-csi to ControllerVolumeContext and NodeVolumeContext: * cephfs-kernelMountOptions, * cephfs-fuseMountOptions * pass cephfs-kernelMountOptions and cephfs-fuseMountOptions to cephfs-csi * updated docs with new volume context opts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
manila-csi already passes mount options to its partner Node Plugins. However, cephfs-csi consumes mount options for CephFS kernel and FUSE client via separate volume context parameters:
kernelMountOptionsandfuseMountOptions. In order for user to be able to control these, manila-csi needs to expose these params as well.Please see https://github.com/ceph/ceph-csi/blob/devel/docs/deploy-cephfs.md#configuration for reference (section "Available volume parameters").
Exposing kernel opts are especially important for environments with SELinux enabled, where users may want to pass in SELinux context options.
Special notes for reviewers:
Release note: