Skip to content

[cinder-csi-plugin] Fix duplicate keys of tolerations#1609

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ramineni:duplicate-tolerations
Jul 28, 2021
Merged

[cinder-csi-plugin] Fix duplicate keys of tolerations#1609
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ramineni:duplicate-tolerations

Conversation

@ramineni
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Fix duplicate keys of tolerations in node plugin yaml
Which issue this PR fixes(if applicable):
fixes #1608

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 27, 2021
@k8s-ci-robot k8s-ci-robot requested review from adisky and zetaab July 27, 2021 13:47
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2021
@ramineni ramineni force-pushed the duplicate-tolerations branch from 9fadbc3 to 3658ac5 Compare July 27, 2021 13:48
@ramineni ramineni force-pushed the duplicate-tolerations branch from 3658ac5 to 1814022 Compare July 27, 2021 13:49
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021
@ramineni ramineni force-pushed the duplicate-tolerations branch from 1814022 to df84dc5 Compare July 27, 2021 13:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021
@jichenjc
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@lingxiankong
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 02cddd3 into kubernetes:master Jul 28, 2021
pierreprinetti pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Aug 23, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] Duplicate tolerations key in chart template nodeplugin-daemonset.yaml

4 participants