[cinder-csi-plugin] Allow overridng kubelet dir in chart values by vs49688 · Pull Request #1615 · kubernetes/cloud-provider-openstack

vs49688 · 2021-08-01T06:16:45Z

What this PR does / why we need it:

The chart assumes Kubelet uses /var/lib/kubelet, which isn't the case on k0s and microk8s (and presumably others). This allows it to be overridden in the values file to handle these cases.

Which issue this PR fixes(if applicable):

Special notes for reviewers:

Release note:

NONE

k8s-ci-robot · 2021-08-01T06:16:48Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-08-01T06:16:52Z

Welcome @vs49688!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-08-01T06:16:52Z

Hi @vs49688. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-08-01T06:17:21Z

Build failed.

cloud-provider-openstack-unittest : NODE_FAILURE in 0s

vs49688 · 2021-08-01T06:19:10Z

Am working on CLA, will probably be a few days.

theopenlab-ci · 2021-08-01T06:23:10Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 4m 01s

brtkwr · 2021-08-02T09:06:05Z

Needs chart version bumping

vs49688 · 2021-08-02T10:01:39Z

Done

brtkwr · 2021-08-02T10:02:30Z

Looks reasonable, thanks

brtkwr · 2021-08-02T10:02:57Z

cc @lingxiankong @ramineni

theopenlab-ci · 2021-08-02T10:14:18Z

Build failed.

cloud-provider-openstack-unittest : NODE_FAILURE in 0s

theopenlab-ci · 2021-08-02T10:19:49Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 3m 51s

ramineni · 2021-08-02T10:25:42Z

/ok-to-test

ramineni · 2021-08-02T10:40:09Z

/check-cla

The chart assumes Kubelet uses /var/lib/kubelet, which isn't the case on k0s and microk8s (and presumably others). This allows it to be overridden in the values file to handle these cases. Also bump chart version to 1.4.7

vs49688 · 2021-08-02T11:53:32Z

New push simply updates author information, for CLA purposes.

theopenlab-ci · 2021-08-02T11:55:25Z

Build failed.

cloud-provider-openstack-unittest : NODE_FAILURE in 0s

theopenlab-ci · 2021-08-02T12:00:29Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 3m 48s

vs49688 · 2021-08-02T12:03:55Z

CLA signed

vs49688 · 2021-08-09T03:13:30Z

Ping on this?

jichenjc · 2021-08-09T03:24:57Z

this is chart only change ,though the gate is having trouble, we should still able to merge? @lingxiankong @ramineni

jichenjc · 2021-08-10T01:27:08Z

/retest

jichenjc · 2021-08-10T01:27:54Z

/lgtm

theopenlab-ci · 2021-08-10T01:33:12Z

Build succeeded.

cloud-provider-openstack-format : SUCCESS in 3m 58s

theopenlab-ci · 2021-08-10T01:35:46Z

Build succeeded.

cloud-provider-openstack-unittest : SUCCESS in 7m 53s

ramineni · 2021-08-10T13:17:48Z

/lgtm
/approve

k8s-ci-robot · 2021-08-10T13:17:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ramineni]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…rnetes#1615) The chart assumes Kubelet uses /var/lib/kubelet, which isn't the case on k0s and microk8s (and presumably others). This allows it to be overridden in the values file to handle these cases. Also bump chart version to 1.4.7

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 1, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 1, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2021

k8s-ci-robot requested review from adisky and jichenjc August 1, 2021 06:16

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2021

vs49688 force-pushed the master branch from b833140 to 5d529d6 Compare August 2, 2021 10:00

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2021

[cinder-csi-plugin] Allow overridng kubelet dir in chart values

e3965ba

The chart assumes Kubelet uses /var/lib/kubelet, which isn't the case on k0s and microk8s (and presumably others). This allows it to be overridden in the values file to handle these cases. Also bump chart version to 1.4.7

vs49688 force-pushed the master branch from 5d529d6 to e3965ba Compare August 2, 2021 11:52

k8s-ci-robot removed the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 2, 2021

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2021

k8s-ci-robot assigned jichenjc Aug 10, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021

k8s-ci-robot assigned ramineni Aug 10, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021

k8s-ci-robot merged commit b2d6dab into kubernetes:master Aug 10, 2021

Conversation

vs49688 commented Aug 1, 2021

Uh oh!

k8s-ci-robot commented Aug 1, 2021

Uh oh!

k8s-ci-robot commented Aug 1, 2021

Uh oh!

k8s-ci-robot commented Aug 1, 2021

Uh oh!

theopenlab-ci Bot commented Aug 1, 2021

Uh oh!

vs49688 commented Aug 1, 2021

Uh oh!

theopenlab-ci Bot commented Aug 1, 2021

Uh oh!

brtkwr commented Aug 2, 2021

Uh oh!

vs49688 commented Aug 2, 2021

Uh oh!

brtkwr commented Aug 2, 2021

Uh oh!

brtkwr commented Aug 2, 2021

Uh oh!

theopenlab-ci Bot commented Aug 2, 2021

Uh oh!

theopenlab-ci Bot commented Aug 2, 2021

Uh oh!

ramineni commented Aug 2, 2021

Uh oh!

ramineni commented Aug 2, 2021

Uh oh!

vs49688 commented Aug 2, 2021

Uh oh!

theopenlab-ci Bot commented Aug 2, 2021

Uh oh!

theopenlab-ci Bot commented Aug 2, 2021

Uh oh!

vs49688 commented Aug 2, 2021

Uh oh!

vs49688 commented Aug 9, 2021

Uh oh!

jichenjc commented Aug 9, 2021

Uh oh!

jichenjc commented Aug 10, 2021

Uh oh!

jichenjc commented Aug 10, 2021

Uh oh!

theopenlab-ci Bot commented Aug 10, 2021

Uh oh!

theopenlab-ci Bot commented Aug 10, 2021

Uh oh!

ramineni commented Aug 10, 2021

Uh oh!

k8s-ci-robot commented Aug 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants