Skip to content

Use bool type for 'allowed' field in authorization response#60

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
lingxiankong:fix-authorization
Mar 28, 2018
Merged

Use bool type for 'allowed' field in authorization response#60
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
lingxiankong:fix-authorization

Conversation

@lingxiankong
Copy link
Copy Markdown
Contributor

@lingxiankong lingxiankong commented Mar 27, 2018

What this PR does / why we need it:
To fix the bug in keystone webhook authorization

Which issue this PR fixes:
fixes #56

Special notes for your reviewer:
The k8s authorizer is expecting a bool type value from WebhookAuthorizer response.

Release note:

NONE

@lingxiankong
Use bool type for 'allowed' field in authorization response
4c17e60 
For #56

The k8s authorizer is expecting a bool type value from
WebhookAuthorizer response.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Mar 27, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 27, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Mar 27, 2018

/assign @Fedosin

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 27, 2018

@dims: GitHub didn't allow me to assign the following users: Fedosin.

Note that only kubernetes members and repo collaborators can be assigned.

Details

In response to this:

/assign @Fedosin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Copy Markdown
Member

dims commented Mar 27, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2018
@hogepodge
Copy link
Copy Markdown
Contributor

hogepodge commented Mar 27, 2018

/approve

@dims
Copy link
Copy Markdown
Member

dims commented Mar 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hogepodge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1f12456 into kubernetes:master Mar 28, 2018
@lingxiankong lingxiankong deleted the fix-authorization branch March 29, 2018 07:01
jsafrane pushed a commit to jsafrane/cloud-provider-openstack that referenced this pull request Aug 23, 2021
@openshift-merge-robot
Merge pull request kubernetes#60 from shiftstack/merge-bot-master
ce3bfd0 
Merge https://github.com/kubernetes/cloud-provider-openstack:master into master
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@k8s-ci-robot
Merge pull request kubernetes#60 from lingxiankong/fix-authorization
1015eac 
Use bool type for 'allowed' field in authorization response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickrenREN NickrenREN Awaiting requested review from NickrenREN

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Authorization failed because of int type value returned instead of bool

4 participants

@lingxiankong @dims @k8s-ci-robot @hogepodge