Add full example for kubernetes.io/cinder provisioner#63
Add full example for kubernetes.io/cinder provisioner#63k8s-ci-robot merged 2 commits intokubernetes:masterfrom theopenlab:cinder-in-tree-example
Conversation
Add kubernetes.io/cinder example, make it easy for beginner to understand the difference with openstack.org/standalone-cinder provisioner.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Have signed CLA. |
|
/assign @hogepodge |
|
/assign @dims |
|
/ok-to-test |
|
@kiwik: you can't request testing unless you are a kubernetes member. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I am not fully sure is this really needed? We have similar example there already if people can combine two files |
|
@zetaab you mean "cinder-storage-class.yaml" and "example-pod.yaml"? looks there is no PVC define. |
|
@zetaab I know your means, I just think if we can quick start a full stack example about kubernetes.io/cinder provisioner in one step "kubectl create -f cinder-in-tree-full.yaml", that is better for beginner than copying piece code from several files. |
|
/ok-to-test |
|
+1 to full complete examples. please do update some doc too when you can that can explain the files. /approve |
|
Can we turn this, and some of the other yaml files into a helm chart? It would be great to be able to helm install the thing rather then tracking down all the individual bits, changing config, then uploading one by one. |
|
@kfox1111 +1 added a issue to track the idea |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add full example for kubernetes.io/cinder provisioner
What this PR does / why we need it:
Add kubernetes.io/cinder example, make it easy for beginner to understand the difference with openstack.org/standalone-cinder provisioner.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):fixes #62
Special notes for your reviewer:
NA
Release note:
NA