Skip to content

Add full example for kubernetes.io/cinder provisioner#63

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
theopenlab:cinder-in-tree-example
Mar 28, 2018
Merged

Add full example for kubernetes.io/cinder provisioner#63
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
theopenlab:cinder-in-tree-example

Conversation

@kiwik
Copy link
Copy Markdown
Contributor

@kiwik kiwik commented Mar 28, 2018

What this PR does / why we need it:
Add kubernetes.io/cinder example, make it easy for beginner to understand the difference with openstack.org/standalone-cinder provisioner.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #62

Special notes for your reviewer:
NA

Release note:
NA

Add kubernetes.io/cinder example, make it easy for beginner to
understand the difference with openstack.org/standalone-cinder
provisioner.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 28, 2018
@kiwik
Copy link
Copy Markdown
Contributor Author

kiwik commented Mar 28, 2018

Have signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2018
@kiwik
Copy link
Copy Markdown
Contributor Author

kiwik commented Mar 28, 2018

/assign @hogepodge

@kiwik
Copy link
Copy Markdown
Contributor Author

kiwik commented Mar 28, 2018

/assign @dims

@kiwik
Copy link
Copy Markdown
Contributor Author

kiwik commented Mar 28, 2018

/ok-to-test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@kiwik: you can't request testing unless you are a kubernetes member.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zetaab
Copy link
Copy Markdown
Member

zetaab commented Mar 28, 2018

I am not fully sure is this really needed? We have similar example there already if people can combine two files

@kiwik
Copy link
Copy Markdown
Contributor Author

kiwik commented Mar 28, 2018

@zetaab you mean "cinder-storage-class.yaml" and "example-pod.yaml"? looks there is no PVC define.

@kiwik
Copy link
Copy Markdown
Contributor Author

kiwik commented Mar 28, 2018

@zetaab I know your means, I just think if we can quick start a full stack example about kubernetes.io/cinder provisioner in one step "kubectl create -f cinder-in-tree-full.yaml", that is better for beginner than copying piece code from several files.

@dims
Copy link
Copy Markdown
Member

dims commented Mar 28, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 28, 2018
@dims
Copy link
Copy Markdown
Member

dims commented Mar 28, 2018

+1 to full complete examples. please do update some doc too when you can that can explain the files.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2018
@kfox1111
Copy link
Copy Markdown

Can we turn this, and some of the other yaml files into a helm chart? It would be great to be able to helm install the thing rather then tracking down all the individual bits, changing config, then uploading one by one.

@dims
Copy link
Copy Markdown
Member

dims commented Mar 28, 2018

@kfox1111 +1 added a issue to track the idea

@dims
Copy link
Copy Markdown
Member

dims commented Mar 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 223c781 into kubernetes:master Mar 28, 2018
@kiwik kiwik deleted the cinder-in-tree-example branch March 29, 2018 01:59
jsafrane pushed a commit to jsafrane/cloud-provider-openstack that referenced this pull request Aug 23, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Add full example for kubernetes.io/cinder provisioner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add full example for kubernetes.io/cinder provisioner

6 participants