[csi-manila] added csi-sanity tests#732
Conversation
csi-sanity v2.1.0 handles the life-times of stage/target directories and will exit with an error if they're created beforehand. This commit removes the Mkdir() calls and leaves it for csi-sanity to handle.
k8s-ci-robot
added
cncf-cla: yes
|
Hi @gman0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XL
|
Build succeeded.
|
|
Build succeeded.
|
|
/ok-to-test |
|
@gman0 Please add document on how to run csi sanity test for manila csi |
|
Build succeeded.
|
|
Build succeeded.
|
k8s-ci-robot
added
ok-to-test
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
@adisky , the sanity test is now being run from the |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-flexvolume-cinder |
|
Build succeeded.
|
gouthampacha
left a comment
gouthampacha
left a comment
There was a problem hiding this comment.
Sweet, I can run this locally,
however, there's a newer version of csi-tests (v2.2.0), can we use that? https://github.com/kubernetes-csi/csi-test/releases
I was able to run these tests with that version:
$ pwd
/home/centos/go/src/k8s.io/cloud-provider-openstack
$ make test-manila-csi-sanity
dep ensure -v
(1/99) Wrote github.com/evanphx/json-patch@5858425f75500d40c52783dce87d085a483ce135
(2/99) Wrote github.com/Azure/go-ansiterm@master
(3/99) Wrote github.com/stretchr/objx@v0.1.1
(4/99) Wrote github.com/container-storage-interface/spec@v1.1.0
(5/99) Wrote github.com/gorilla/mux@v1.7.0
(6/99) Wrote github.com/hashicorp/hcl@v1.0.0
(7/99) Wrote github.com/stretchr/testify@v1.3.0
(8/99) Wrote github.com/NYTimes/gziphandler@v1.1.1
(9/99) Wrote golang.org/x/crypto@master
(10/99) Wrote github.com/gophercloud/utils@master
(11/99) Wrote github.com/PuerkitoBio/purell@v1.1.1
(12/99) Wrote github.com/PuerkitoBio/urlesc@master
(13/99) Wrote github.com/hashicorp/golang-lru@v0.5.1
(14/99) Wrote github.com/beorn7/perks@master
(15/99) Wrote github.com/grpc-ecosystem/go-grpc-prometheus@v1.2.0
(16/99) Wrote sigs.k8s.io/yaml@v1.1.0
(17/99) Wrote github.com/gophercloud/gophercloud@master
(18/99) Wrote golang.org/x/net@master
(19/99) Wrote golang.org/x/sys@master
(20/99) Wrote golang.org/x/oauth2@master
(21/99) Wrote github.com/coreos/go-systemd@v18
(22/99) Wrote golang.org/x/text@v0.3.0
(23/99) Wrote golang.org/x/time@master
(24/99) Wrote google.golang.org/grpc@v1.19.0
(25/99) Wrote gopkg.in/fsnotify.v1 (from https://github.com/fsnotify/fsnotify.git)@v1.4.7
(26/99) Wrote github.com/hpcloud/tail@v1.0.0
(27/99) Wrote github.com/imdario/mergo@v0.3.7
(28/99) Wrote google.golang.org/appengine@v1.4.0
(29/99) Wrote github.com/inconshreveable/mousetrap@v1.0
(30/99) Wrote github.com/konsorten/go-windows-terminal-sequences@v1.0.2
(31/99) Wrote github.com/json-iterator/go@v1.1.6
(32/99) Wrote github.com/coreos/etcd@v3.3.12
(33/99) Wrote google.golang.org/genproto@master
(34/99) Wrote github.com/davecgh/go-spew@v1.1.1
(35/99) Wrote github.com/emicklei/go-restful@v2.9.0
(36/99) Wrote github.com/magiconair/properties@v1.8.0
(37/99) Wrote gopkg.in/inf.v0@v0.9.1
(38/99) Wrote gopkg.in/natefinch/lumberjack.v2@v2.1
(39/99) Wrote gopkg.in/tomb.v1@v1
(40/99) Wrote gopkg.in/yaml.v2@v2.2.2
(41/99) Wrote gopkg.in/warnings.v0@v0.1.2
(42/99) Wrote gopkg.in/square/go-jose.v2@v2.3.0
(43/99) Wrote k8s.io/client-go@kubernetes-1.15.0
(44/99) Wrote github.com/kubernetes-csi/csi-lib-utils (from https://github.com/kubernetes-csi/csi-lib-utils)@v0.6.1
(45/99) Wrote k8s.io/apiextensions-apiserver@kubernetes-1.15.0
(46/99) Wrote github.com/mailru/easyjson@master
(47/99) Wrote github.com/docker/distribution@v2.7.1
(48/99) Wrote github.com/matttproud/golang_protobuf_extensions@v1.0.1
(49/99) Wrote k8s.io/api@kubernetes-1.15.0
(50/99) Wrote github.com/mitchellh/mapstructure@v1.1.2
(51/99) Wrote github.com/modern-go/concurrent@1.0.3
(52/99) Wrote github.com/mitchellh/go-homedir@v1.1.0
(53/99) Wrote github.com/munnerz/goautoneg@master
(54/99) Wrote github.com/modern-go/reflect2@1.0.1
(55/99) Wrote github.com/onsi/gomega@v1.5.0
(56/99) Wrote github.com/onsi/ginkgo@v1.8.0
(57/99) Wrote github.com/opencontainers/go-digest@v1.0.0-rc1
(58/99) Wrote github.com/pborman/uuid@v1.2
(59/99) Wrote github.com/pmezard/go-difflib@v1.0.0
(60/99) Wrote github.com/pelletier/go-toml@v1.2.0
(61/99) Wrote github.com/prometheus/client_golang@v0.9.2
(62/99) Wrote github.com/prometheus/client_model@master
(63/99) Wrote github.com/prometheus/procfs@master
(64/99) Wrote github.com/prometheus/common@v0.2.0
(65/99) Wrote github.com/sirupsen/logrus@v1.4.0
(66/99) Wrote github.com/spf13/afero@v1.2.1
(67/99) Wrote github.com/spf13/cast@v1.3.0
(68/99) Wrote github.com/spf13/jwalterweatherman@v1.1.0
(69/99) Wrote github.com/miekg/dns@v1.1.6
(70/99) Wrote github.com/spf13/cobra@v0.0.3
(71/99) Wrote github.com/spf13/pflag@v1.0.3
(72/99) Wrote k8s.io/apimachinery@kubernetes-1.15.0
(73/99) Wrote github.com/spf13/viper@v1.3.2
(74/99) Wrote github.com/docker/docker@a9fbbdc8dd8794b20af358382ab780559bca589d
(75/99) Wrote github.com/fsnotify/fsnotify@v1.4.7
(76/99) Wrote github.com/go-openapi/jsonpointer@v0.18.0
(77/99) Wrote github.com/go-openapi/jsonreference@v0.18.0
(78/99) Wrote github.com/go-openapi/swag@v0.18.0
(79/99) Wrote github.com/google/go-cmp@v0.3.0
(80/99) Wrote github.com/go-openapi/spec@v0.18.0
(81/99) Wrote github.com/golang/groupcache@master
(82/99) Wrote k8s.io/cloud-provider@kubernetes-1.15.0
(83/99) Wrote github.com/golang/protobuf@v1.3.0
(84/99) Wrote k8s.io/kube-controller-manager@master
(85/99) Wrote k8s.io/klog@v0.2.0
(86/99) Wrote k8s.io/component-base@kubernetes-1.15.0
(87/99) Wrote github.com/google/uuid@v1.1.1
(88/99) Wrote github.com/google/gofuzz@master
(89/99) Wrote k8s.io/utils@master
(90/99) Wrote k8s.io/csi-translation-lib@master
(91/99) Wrote github.com/gogo/protobuf@v1.2.1
(92/99) Wrote github.com/kubernetes-csi/csi-test@v2.2.0
(93/99) Wrote sigs.k8s.io/sig-storage-lib-external-provisioner@master
(94/99) Wrote gopkg.in/gcfg.v1@v1.2.3
(95/99) Wrote sigs.k8s.io/structured-merge-diff@e85c7b244fd2cc57bb829d73a061f93a441e63ce
(96/99) Wrote github.com/googleapis/gnostic@v0.2.0
(97/99) Wrote k8s.io/apiserver@kubernetes-1.15.0
(98/99) Wrote k8s.io/kube-openapi@master
(99/99) Wrote k8s.io/kubernetes@v1.15.0
go test k8s.io/cloud-provider-openstack/pkg/csi/manila/sanity/
ok k8s.io/cloud-provider-openstack/pkg/csi/manila/sanity 0.124s
|
@gouthampacha updated in 705c484 |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build failed.
|
|
Build succeeded.
|
|
/test cloud-provider-openstack-acceptance-test-standalone-cinder |
|
Build succeeded.
|
|
|
||
| type fakeIdentitySvcClient struct{} | ||
|
|
||
| func (c fakeIdentitySvcClient) GetPluginInfo(context.Context) (*csi.GetPluginInfoResponse, error) { |
There was a problem hiding this comment.
just curious...why you need to fakeIdentitySvcClient, fakeNodeSvcClient?? sanity tests needs to fake cloud/mount functionality only, not nodeserver and identity server methods?
There was a problem hiding this comment.
CSI Manila takes on a bit different approach than Cinder. All node-related operations are delegated to, and performed by a dedicated Node Plugin (see the docs here).
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adisky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Gopkg: added github.com/kubernetes-csi/csi-test v2.1.0 dependency * CSI Cinder: updated sanity tests to support csi-sanity v2.1.0 csi-sanity v2.1.0 handles the life-times of stage/target directories and will exit with an error if they're created beforehand. This commit removes the Mkdir() calls and leaves it for csi-sanity to handle. * added csi-sanity tests for CSI Manila * added check for gophercloud.ErrResourceNotFound * use k8s.io/cloud-provider-openstack/pkg/util/errors convenience functions * added csi-manila sanity test to test-csi-sanity build target * added instructions for running sanity test to dev docs * added separate build targets for running CSI sanity tests * updated csi-test dependency to v2.2.0
5 participants
What this PR does / why we need it:
This is the 4th PR of #714 which concludes the integration of csi-sanity test suite into the CSI Manila driver.
Mkdir()calls had to be removed.Which issue this PR fixes: fixes #714
Release note: