Skip to content

Add libnss_wrapper and a wrapper to use it#155

Closed
Vampouille wants to merge 1 commit intokubernetes:masterfrom
Vampouille:add_nss_wrapper
Closed

Add libnss_wrapper and a wrapper to use it#155
Vampouille wants to merge 1 commit intokubernetes:masterfrom
Vampouille:add_nss_wrapper

Conversation

@Vampouille
Copy link

Compile libnss_wrapper from source and create a script that populate at
runtime passwd/group databases with current running user.

Compile libnss_wrapper from source and create a script that populate at
runtime passwd/group databases with current running user.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: thockin

If they are not already assigned, you can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Vampouille
Copy link
Author

I'm not very confortable with building libnss_wrapper in this image as said by @tianon here : docker-library/postgres#543 it is the responsibility of this repository to maintain build instructions of libnss_wrapper ?

@thockin
Copy link
Member

thockin commented Mar 18, 2019

If we switch to debian as a base, this gets easier right? #154


RUN echo "git-sync:x:65533:65533::/tmp:/sbin/nologin" >> /etc/passwd

# Compile libnss_wrapper (see https://bugs.alpinelinux.org/issues/6710)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we switch to debian as a base, this gets easier right?

Yes we can remove this build part

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2019
@thockin
Copy link
Member

thockin commented Jun 17, 2019

/lifecycle frozen
/remove-lifecycle stale
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 17, 2019
@thockin
Copy link
Member

thockin commented Oct 25, 2019

Closing as abandoned for now.

@thockin thockin closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants