Skip to content

[release-1.34] etcd: bump etcd to v3.6.5 #134426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Oct 17, 2025
Merged

[release-1.34] etcd: bump etcd to v3.6.5 #134426

k8s-ci-robot merged 2 commits into from
Oct 17, 2025

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 5, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Verify/test latest etcd patch v3.6.5 in workflow

Which issue(s) this PR is related to:

etcd-io/etcd#20501

Does this PR introduce a user-facing change?

updated etcd to v3.6.5.

cc @hakman @ivanvc @joshjms

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 5, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Oct 5, 2025
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from bowei and mkumatag October 5, 2025 18:15
@ahrtr
Copy link
Member Author

ahrtr commented Oct 5, 2025

Link to #134251

cc @dims @neolit123

@ahrtr
Copy link
Member Author

ahrtr commented Oct 5, 2025

/test pull-kubernetes-e2e-gce

@hakman
Copy link
Member

hakman commented Oct 5, 2025 •
edited
Loading

@ahrtr @joshjms I think #134268 needs to be cherrypicked first/also.
Similar for any other K8s release where the official images will be used.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 5, 2025

@ahrtr @joshjms I think #134268 needs to be cherrypicked first/also. Similar for any other K8s release where the official images will be used.

thx. @joshjms do you have bandwidth to backport the PR? If not, I will take care of it tomorrow my time.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2025
@ahrtr
Copy link
Member Author

ahrtr commented Oct 6, 2025

@ahrtr @joshjms I think #134268 needs to be cherrypicked first/also. Similar for any other K8s release where the official images will be used.

thx. @joshjms do you have bandwidth to backport the PR? If not, I will take care of it tomorrow my time.

Manually cherry picked #134431

neolit123
neolit123 reviewed Oct 6, 2025
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@ahrtr
Do not validate etcd version for aggregated server conformance test
30fd266 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@hakman
Copy link
Member

hakman commented Oct 17, 2025

/retest

sriramandev
sriramandev reviewed Oct 17, 2025
View reviewed changes
@ahrtr
Copy link
Member Author

ahrtr commented Oct 17, 2025

I believe I have resolved all review comments, please all owners take a look, thx

cc @dims @liggitt @BenTheElder @bowei

cc @hakman @joshjms

@ahrtr
Copy link
Member Author

ahrtr commented Oct 17, 2025

cc @kubernetes/release-managers

@dims
Copy link
Member

dims commented Oct 17, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@xmudrii
Copy link
Member

xmudrii commented Oct 17, 2025

This is missing the LGTM label before it can be approved by Release Managers. cc @dims @hakman

@liggitt
Copy link
Member

liggitt commented Oct 17, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 17, 2025

LGTM label has been added.

Git tree hash: f72eba2dad2bcf35db2fa2e96b75eb083032d915

xmudrii
xmudrii approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, dims, hakman, neolit123, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@humblec
Copy link
Contributor

humblec commented Oct 17, 2025

/lgtm

@hakman
Copy link
Member

hakman commented Oct 17, 2025

/lgtm

@ahrtr
Copy link
Member Author

ahrtr commented Oct 17, 2025

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 17, 2025
@ahrtr
Copy link
Member Author

ahrtr commented Oct 17, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1d558ae into kubernetes:release-1.34 Oct 17, 2025
16 checks passed
@ahrtr
Copy link
Member Author

ahrtr commented Oct 17, 2025

thx all for the review & help!

@ahrtr ahrtr mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@xmudrii xmudrii xmudrii approved these changes

@bowei bowei Awaiting requested review from bowei

@mkumatag mkumatag Awaiting requested review from mkumatag

@neolit123 neolit123 Awaiting requested review from neolit123

@hakman hakman Awaiting requested review from hakman

+2 more reviewers

@joshjms joshjms joshjms left review comments

@sriramandev sriramandev sriramandev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@neolit123 neolit123

@liggitt liggitt

@hakman hakman

@humblec humblec

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

[sig-release] Bug Triage
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

10 participants

@ahrtr @hakman @k8s-ci-robot @neolit123 @joshjms @xmudrii @dims @liggitt @humblec @sriramandev