SANDBOX-686 Upgrade k8s depencencies in ksctl for Openshift 4.16#103
Merged
ranakan19 merged 5 commits intokubesaw:masterfrom Feb 3, 2025
Merged
SANDBOX-686 Upgrade k8s depencencies in ksctl for Openshift 4.16#103ranakan19 merged 5 commits intokubesaw:masterfrom
ranakan19 merged 5 commits intokubesaw:masterfrom
Conversation
ranakan19
requested review from
MatousJobanek,
alexeykazakov,
drpaneas,
fbm3307,
metlos,
mfrancisc,
rajivnathan and
xcoulon
as code owners
rsoaresd
reviewed
Jan 20, 2025
Contributor
rsoaresd
left a comment
rsoaresd
left a comment
There was a problem hiding this comment.
Nice work 🚀 Just minor suggestion:
rsoaresd
reviewed
Jan 20, 2025
rsoaresd
reviewed
Jan 20, 2025
MatousJobanek
approved these changes
Jan 21, 2025
alexeykazakov
approved these changes
Jan 22, 2025
fbm3307
approved these changes
Jan 22, 2025
fbm3307
reviewed
Jan 22, 2025
ranakan19
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 68.32% 68.32%
=======================================
Files 44 44
Lines 3343 3343
=======================================
Hits 2284 2284
Misses 851 851
Partials 208 208
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades:
wrt: https://issues.redhat.com/browse/SANDBOX-686