Skip to content

Added classification to alerts#102

Merged
BenMic5 merged 1 commit into
mainfrom
feat/add-classification-to-alerts
Apr 16, 2026
Merged

Added classification to alerts#102
BenMic5 merged 1 commit into
mainfrom
feat/add-classification-to-alerts

Conversation

@BenMic5
Copy link
Copy Markdown
Collaborator

@BenMic5 BenMic5 commented Apr 15, 2026

Summary by CodeRabbit

  • New Features
    • Incident messages can now optionally include classification information in their payload.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@BenMic5 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 25 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 25 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc6e3245-668b-47d9-87bf-7076b5887909

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc359e and e0a8e73.

📒 Files selected for processing (1)
  • pulsar/common/kdr/datastructures.go
📝 Walkthrough

Walkthrough

A single public field Classification of type string has been added to the RuntimeIncidentIngesterOnFinishedMessage struct in the datastructures module, allowing optional classification data to be serialized in the JSON payload.

Changes

Cohort / File(s) Summary
Struct Field Addition
pulsar/common/kdr/datastructures.go
Added Classification field to RuntimeIncidentIngesterOnFinishedMessage struct with omitempty JSON tag for optional serialization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a field so new,
Classification—we'll add it too!
One line of code, a simple grace,
Categorizing every case. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Added classification to alerts' accurately describes the main change: adding a Classification field to RuntimeIncidentIngesterOnFinishedMessage for alert classification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-classification-to-alerts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

Signed-off-by: Ben Michael <benm@armosec.io>
@BenMic5 BenMic5 force-pushed the feat/add-classification-to-alerts branch from 7dc359e to e0a8e73 Compare April 15, 2026 08:57
@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

@BenMic5 BenMic5 merged commit e2c80ac into main Apr 16, 2026
8 checks passed
@matthyx matthyx moved this to To Archive in KS PRs tracking Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants