fix(cleanup): enhance pod deletion logic and add tests for standalone pods

[matthyx]

Summary by CodeRabbit

• Bug Fixes

  • Improved cleanup operations to properly handle pod-based workloads as cleanable resource types. Pods are now correctly processed during cleanup cycles, ensuring orphaned pod profiles are appropriately removed.

• Tests

  • Added tests validating pod cleanup behavior in standalone scenarios, confirming proper profile removal and retention across different workload configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6522328-f225-4ba9-8c2b-501cf23d0021

📥 Commits

Reviewing files that changed from the base of the PR and between 2dbea36 and 8be42b9.

📒 Files selected for processing (2)

• pkg/registry/file/cleanup.go
• pkg/registry/file/cleanup_test.go

---

📝 Walkthrough

Walkthrough

The changes extend the workload cleanup logic to recognize "pod" as a cleanable workload kind by introducing an isCleanableWlidKind helper function. A new test suite validates cleanup behavior for standalone pod workloads with specific label and annotation configurations.

Changes

Cohort / File(s)	Summary
Workload Kind Validation pkg/registry/file/cleanup.go	Introduced isCleanableWlidKind helper function to route workload kind validation. Now treats "pod" as cleanable, replacing direct Workloads containment check in deleteByWlid logic.
Standalone Pod Cleanup Tests pkg/registry/file/cleanup_test.go	Added new unit test suite for deleteByTemplateHashOrWlid with pod-scoped ObjectMeta. Tests deletion and preservation scenarios based on workload-id mapping presence in ResourceMaps.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A helper hops in, declaring pods are clean,
No more workload walls standing in between,
Tests verify each hop with care,
Pod cleanup logic, fair and square! 🧹✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: enhancing pod deletion logic and adding tests for standalone pods, which matches the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch clean-standalone-pods

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: success
• Unit test: success
• Go linting: failure