disable WatchList flag until we support it

[matthyx]

Summary by CodeRabbit

• Bug Fixes
  • Disabled the WatchList feature in the file-based storage backend to prevent compatibility issues; the server startup now ensures WatchList remains off (ServerSideApply also remains disabled). A comment clarifies WatchList is not yet supported in file-based storage.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 844e5e72-24d2-481b-872c-3dbf33e1a9eb

📥 Commits

Reviewing files that changed from the base of the PR and between 5e585ce and 071631e.

📒 Files selected for processing (1)

• pkg/cmd/server/start.go

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/cmd/server/start.go

---

📝 Walkthrough

Walkthrough

The PR updates NewCommandStartWardleServer's PersistentPreRunE to set feature-gates to include WatchList=false and adds a comment that WatchList is not implemented for the file-based storage backend.

Changes

Feature Gate Configuration

Layer / File(s)	Summary
Disable WatchList feature gate pkg/cmd/server/start.go	The command's PersistentPreRunE hook sets feature-gates to include WatchList=false alongside ServerSideApply=false, and adds a comment noting WatchList is not implemented in the file-based storage backend.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• kubescape/storage#298: Both PRs modify pkg/cmd/server/start.go’s NewCommandStartWardleServer/PersistentPreRunE to set feature-gates via cmd.Flags().Set(...).

Poem

🐰 I hopped to the code with a thoughtful twitch,
Flipped a small switch for WatchList to nix,
A comment I left where the backend sleeps,
Quiet flags now guard configuration keeps,
Hooray for tiny fixes—soft as a stitch.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: disabling the WatchList flag until support is implemented, which directly corresponds to the code modification adding WatchList=false to feature gates.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch watchlist

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/cmd/server/start.go`:
- Around line 146-149: The two consecutive calls to flags.Set("feature-gates",
...) overwrite each other so "ServerSideApply=false" is lost; modify the code
that sets feature gates (the flags.Set("feature-gates", ...) calls) to provide
both gates in a single comma-separated value (e.g.
"ServerSideApply=false,WatchList=false") or read the existing feature-gates
value and append ",WatchList=false" before calling flags.Set, ensuring both
gates are present in one flags.Set invocation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 95855111-045a-4f5b-acba-149ed791323e

📥 Commits

Reviewing files that changed from the base of the PR and between 2a689d8 and 5e585ce.

📒 Files selected for processing (1)

• pkg/cmd/server/start.go

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: success
• Unit test: success
• Go linting: failure

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: success
• Unit test: success
• Go linting: failure

[matthyx]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.