Skip to content

Conversation

@redscholar
Copy link
Contributor

@redscholar redscholar commented Dec 29, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

multi version for download

Additional documentation, usage docs, etc.:

@kubesphere-prow kubesphere-prow bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed labels Dec 29, 2025
@kubesphere-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @redscholar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the system's ability to manage and download multiple versions of various core infrastructure components. By introducing a detailed and centralized configuration within 10-download.yaml, it provides greater flexibility in specifying desired versions for Kubernetes, Helm, CNI solutions, container runtimes, and image registries, paving the way for more adaptable deployments.

Highlights

  • Multi-version Download Configuration: Introduced a new configuration structure to support multiple versions for various downloadable components, centralizing version management.
  • Expanded Component Versioning: Added explicit version lists for Kubernetes, Helm, CNI plugins (Calico, Cilium, KubeOVN, Hybridnet), Container Runtime Interfaces (Docker, Containerd), and image registries (Harbor).
  • Centralized Configuration: All new version definitions are consolidated under the download section within the 10-download.yaml file, streamlining configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kubesphere-prow kubesphere-prow bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed labels Dec 29, 2025
@redscholar redscholar added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note labels Dec 29, 2025
@kubesphere-prow kubesphere-prow bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed labels Dec 29, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for defining multiple versions of components for download by updating the 10-download.yaml configuration file. The changes are a good step towards more flexible version management. However, I've found a few issues in the new configuration: a duplicate Kubernetes version, a YAML formatting error, and placeholder values for etcd_version and image_manifests that could cause errors. I've provided suggestions to fix these issues.

# runc binary
runc_version: ["v1.1.7"]
etcd:
etcd_version: [""]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The etcd_version list contains an empty string [""]. This is likely a placeholder or an error. An empty version string will probably cause failures during the download process when constructing artifact URLs. Please replace it with a valid etcd version or an empty list [] if no versions are supported yet.

    etcd_version: []

Comment on lines 53 to 54
image_manifests:
- xxx

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The image_manifests list contains a placeholder value "xxx". This will likely cause an error when this value is processed. This should be removed. If no manifests are intended, the list should be empty.

  image_manifests: []

@@ -1,4 +1,58 @@
download:
kubernetes:
kube_version: ["v1.23.17", "v1.24.17", "v1.25.16", "v1.25.16", "v1.26.15", "v1.27.16", "v1.28.15", "v1.29.15", "v1.30.14", "v1.31.14", "v1.32.11", "v1.33.7"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Kubernetes version v1.25.16 is listed twice in the kube_version array. This appears to be a copy-paste error and the duplicate should be removed to avoid redundancy and potential issues.

    kube_version: ["v1.23.17", "v1.24.17", "v1.25.16", "v1.26.15", "v1.27.16", "v1.28.15", "v1.29.15", "v1.30.14", "v1.31.14", "v1.32.11", "v1.33.7"]

# docker_registry_version: ["2.8.3"]
cni:
type: ["calico"]
# ========== cni ==========

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment # ========== cni ========== is incorrectly indented. It should be aligned with the keys at the same level to maintain consistent and valid YAML formatting.

    # ========== cni ==========

@zuoxuesong-worker
Copy link
Contributor

it will cause all download and copy fail with error.
and it would need a lot of change to download and copy
maybe we can continue our current download task
if user need multi version binaries ,what about this example:

kk export artifact -c version1.yaml # download binaries for version1
kk export artifact -c version2.yaml # download binaries for version2
kk export artifact -c version3.yaml --download_image --pack # download binaries for version3, only download img and make tgz in the last run

@kubesphere-prow kubesphere-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2025
@redscholar redscholar force-pushed the multi-download branch 3 times, most recently from 2bcf282 to 92297b9 Compare January 6, 2026 02:14
@kubesphere-prow kubesphere-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@redscholar redscholar force-pushed the multi-download branch 2 times, most recently from 3fbac57 to c88acaa Compare January 6, 2026 11:01
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
@redscholar redscholar added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@kubesphere-prow kubesphere-prow bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 6, 2026
@kubesphere-prow kubesphere-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 6, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants