-
Notifications
You must be signed in to change notification settings - Fork 814
feat: multi version for download #2921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @redscholar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's ability to manage and download multiple versions of various core infrastructure components. By introducing a detailed and centralized configuration within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for defining multiple versions of components for download by updating the 10-download.yaml configuration file. The changes are a good step towards more flexible version management. However, I've found a few issues in the new configuration: a duplicate Kubernetes version, a YAML formatting error, and placeholder values for etcd_version and image_manifests that could cause errors. I've provided suggestions to fix these issues.
| # runc binary | ||
| runc_version: ["v1.1.7"] | ||
| etcd: | ||
| etcd_version: [""] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The etcd_version list contains an empty string [""]. This is likely a placeholder or an error. An empty version string will probably cause failures during the download process when constructing artifact URLs. Please replace it with a valid etcd version or an empty list [] if no versions are supported yet.
etcd_version: []| image_manifests: | ||
| - xxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,4 +1,58 @@ | |||
| download: | |||
| kubernetes: | |||
| kube_version: ["v1.23.17", "v1.24.17", "v1.25.16", "v1.25.16", "v1.26.15", "v1.27.16", "v1.28.15", "v1.29.15", "v1.30.14", "v1.31.14", "v1.32.11", "v1.33.7"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kubernetes version v1.25.16 is listed twice in the kube_version array. This appears to be a copy-paste error and the duplicate should be removed to avoid redundancy and potential issues.
kube_version: ["v1.23.17", "v1.24.17", "v1.25.16", "v1.26.15", "v1.27.16", "v1.28.15", "v1.29.15", "v1.30.14", "v1.31.14", "v1.32.11", "v1.33.7"]| # docker_registry_version: ["2.8.3"] | ||
| cni: | ||
| type: ["calico"] | ||
| # ========== cni ========== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
it will cause all download and copy fail with error. |
009f420 to
43ace19
Compare
2bcf282 to
92297b9
Compare
3fbac57 to
c88acaa
Compare
Signed-off-by: redscholar <blacktiledhouse@gmail.com>
c88acaa to
e02c7d0
Compare
|



What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: