Fix: Extend Import Cluster CSR timeout#2407
Fix: Extend Import Cluster CSR timeout#2407DhruvTotala wants to merge 1 commit intokubestellar:devfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @DhruvTotala. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Increased the CSR approval wait time from 30s to 5m in backend/api/handlers.go to support slower environments. Fixes kubestellar#2392. Signed-off-by: dhruv <dhruvtotla30@gmail.com>
e6c1ffb to
bd503a1
Compare
|
/ok-to-test |
Description
This PR fixes a bug in the "Import Cluster" (Quick Connect) workflow where the operation frequently times out in environments with slower agent startup times.
Currently, the backend only checks for the Certificate Signing Request (CSR) briefly (~30 seconds). If the agent takes longer to start and generate the CSR, the import process hangs or fails. This change replaces the single-pass check with a polling loop that waits up to 5 minutes, ensuring robustness across various network and hardware conditions.
Related Issue
Fixes #2392
Changes Made
approveClusterCSRsinbackend/api/handlers.go.Checklist
Additional Notes
This change does not impact the UI. It significantly improves backend API reliability for the "Quick Connect" feature.
Test Plan: Verified in a local environment with simulated agent startup delays.