feat(core): add Sharing domain project mappings#1044
Merged
kunickiaj merged 1 commit intoMay 6, 2026
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 6, 2026
12 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 335c14fec4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kunickiaj
force-pushed
the
05-05-feat_core_add_sharing_domain_project_mappings
branch
from
335c14f to
e5f66d3
Compare
Owner
Author
Merge activity
|
kunickiaj
added a commit
that referenced
this pull request
May 6, 2026
## Description Adds viewer-server settings endpoints for Sharing-domain project mappings on top of the core helpers. The API lists domains/projects/mappings, saves mappings with strict field validation, rejects inactive or unknown `scope_id` values, and does not mutate `scope_memberships`. Stack slice: viewer API for codemem-ov4g.6.1. Depends on #1044. ## Type of Change - [x] 🚀 Feature (new functionality) - [ ] 🐛 Bug fix (fixes an issue) - [ ] 📚 Documentation (docs-only change) - [ ] 🔧 Maintenance (refactor, chore, CI, etc.) - [x] 🧪 Testing (test-only changes) ## Testing - [x] Relevant checks pass locally (`pnpm run tsc`, `pnpm run lint`, `pnpm run test`) - [x] Added/updated tests for changes - [ ] Manually verified changes work as expected Validation run: - `pnpm exec vitest run packages/viewer-server/src/index.test.ts -t "updates local Sharing domain project mappings without granting membership"` - `pnpm run tsc` - touched-file Biome check ## Checklist - [x] Code follows project style (`pnpm run lint` passes for touched files) - [x] Self-review completed - [x] Documentation updated (if needed) - [x] No new warnings introduced
kunickiaj
added a commit
that referenced
this pull request
May 6, 2026
## Description Adds the Settings UI surface for assigning known projects to Sharing domains. The panel shows Local-only fallback for unmapped/unknown projects, saves explicit project mappings through the viewer API, and avoids presenting coordinator/group membership as data access. Stack slice: UI for codemem-ov4g.6.1. Depends on #1044 and #1045. ## Type of Change - [x] 🚀 Feature (new functionality) - [ ] 🐛 Bug fix (fixes an issue) - [ ] 📚 Documentation (docs-only change) - [ ] 🔧 Maintenance (refactor, chore, CI, etc.) - [x] 🧪 Testing (test-only changes) ## Testing - [x] Relevant checks pass locally (`pnpm run tsc`, `pnpm run lint`, `pnpm run test`) - [x] Added/updated tests for changes - [ ] Manually verified changes work as expected Validation run: - `pnpm exec vitest run packages/ui/src/tabs/settings/components/SharingDomainsPanel.test.tsx` - `pnpm --filter @codemem/ui build` - `pnpm run tsc` - touched-file Biome check ## Checklist - [x] Code follows project style (`pnpm run lint` passes for touched files) - [x] Self-review completed - [x] Documentation updated (if needed) - [x] No new warnings introduced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds core helpers for local project-to-Sharing-domain settings: list active domains, derive project candidates, and upsert/delete project mappings. Workspace-id-only and unknown/unmapped sessions are surfaced as Local only, and mapping writes validate active
scope_idvalues without grantingscope_memberships.Stack slice: core foundation for codemem-ov4g.6.1.
Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Validation run:
pnpm exec vitest run packages/core/src/project-scope-settings.test.tspnpm run tscChecklist
pnpm run lintpasses for touched files)